@bobrippling could you take a look at the checker output? Something is going wrong:

TypeError: app.tags.split is not a function
    at /home/runner/work/BangleApps/BangleApps/bin/sanitycheck.js:209:37
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/runner/work/BangleApps/BangleApps/bin/sanitycheck.js:197:6)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    at node:internal/main/run_main_module:28:49

Ah, I think in metadata.json tags: is not an array, just a string, eg: "clock". The checker doesn't know how to split the array, since it should be a string. Hope that helps!

Yeah that was it - LGTM but will let you finish your review if you like @thyttan

You're close now 😉 : https://github.com/espruino/BangleApps/actions/runs/18608508358/job/53074607304#step:5:8

So add icon for the app loader and launchers and we're probably good to go.

You'll also need an app.png file with the icon of the app, not ported to JS. The js icon is for the watch to display it in launchers, and the .png icon is for the app loader. So adding a app.png file with the png version of the app icon in app-icon.js will make this good to go!

I'm going to cancel this pull request and start another with that file. I'm not sure if there's any other way to add a file to a current commit.

I'm going to cancel this pull request and start another with that file. I'm not sure if there's any other way to add a file to a current commit.

How do you develop the app. Do you use the github web interface or do you use git locally on your machine and do push/pull to github?

In either case - if you add commits to the PR branch (LucienStorm:master for this one) those commits will show up on the PR automatically. That way we get a continuous thread working towards merging your contribution. 👍

Yeah, adding files is also possible in an open PR as well :)

Just keep it in mind for next time...

That's good to know, I'm just starting to actually use GitHub in this way, so I don't know the proper procedures.
I also have been unable to find the place that says more than 'failed' so I can see exactly why it failed.

I've been using the web page to upload.

Sorry for the confusion I've caused.

I'm going to cancel this pull request and start another with that file. I'm not sure if there's any other way to add a file to a current commit.

How do you develop the app. Do you use the github web interface or do you use git locally on your machine and do push/pull to github?

In either case - if you add commits to the PR branch (LucienStorm:master for this one) those commits will show up on the PR automatically. That way we get a continuous thread working towards merging your contribution. 👍

It's par for the course when starting out - thanks for contributing! :)

I've been using the web page to upload.

Ok. So like said above if you modify or add files to a branch that's connected to a PR they will keep in sync.

Also if you want to develop several apps in parallell I engourage you to look into using different branches. Then you can open PR's from different branches to keep things separated. That will help you and us maintainers both :)

Here is documentation from github on branches: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches